-
Notifications
You must be signed in to change notification settings - Fork 2
POST: May 2025 - Visible App tracking #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 The preview is built! Check it out 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 18 out of 19 changed files in this pull request and generated no comments.
Files not reviewed (1)
- .gitmodules: Language not supported
🎉 The preview is built! Check it out 👀 |
🎉 The preview is built! Check it out 👀 |
🎉 The preview is built! Check it out 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements configuration changes to support Visible App tracking for the May 2025 release. Key changes include updating the baseURL to a relative path and adding new Goldmark parser settings to control image wrapping in markdown.
Files not reviewed (3)
- .gitmodules: Language not supported
- content/blog/2025/05-01_visible/index_cache/markdown_strict/__packages: Language not supported
- themes/hugo-igloo: Language not supported
baseURL = "./" | ||
theme = "hugo-igloo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the baseURL from an empty string to a relative path ('./') may impact link resolution or asset loading in production. Consider using an environment-specific absolute URL for production or documenting the intent clearly.
baseURL = "./" | |
theme = "hugo-igloo" | |
baseURL = "https://drmowinckels.io" # Set to the production domain for consistent link resolution and asset loading |
Copilot uses AI. Check for mistakes.
[markup.goldmark.renderer] | ||
unsafe = true | ||
[markup.goldmark.parser] | ||
wrapStandAloneImageWithinParagraph = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The property name 'wrapStandAloneImageWithinParagraph' appears to use mixed case for 'standAlone'; consider using 'wrapStandaloneImageWithinParagraph' if that is the intended configuration key as per documentation.
wrapStandAloneImageWithinParagraph = false | |
wrapStandaloneImageWithinParagraph = false |
Copilot uses AI. Check for mistakes.
No description provided.