Skip to content

POST: May 2025 - Visible App tracking #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 1, 2025
Merged

POST: May 2025 - Visible App tracking #107

merged 10 commits into from
May 1, 2025

Conversation

drmowinckels
Copy link
Owner

No description provided.

Copy link
Contributor

🎉 The preview is built! Check it out 👀

@drmowinckels drmowinckels requested a review from Copilot April 26, 2025 18:20
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 18 out of 19 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • .gitmodules: Language not supported

Copy link
Contributor

🎉 The preview is built! Check it out 👀

Copy link
Contributor

🎉 The preview is built! Check it out 👀

Copy link
Contributor

🎉 The preview is built! Check it out 👀

@drmowinckels drmowinckels requested a review from Copilot April 28, 2025 17:40
@drmowinckels drmowinckels added the pending Post pending, scheduled label Apr 28, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements configuration changes to support Visible App tracking for the May 2025 release. Key changes include updating the baseURL to a relative path and adding new Goldmark parser settings to control image wrapping in markdown.

Files not reviewed (3)
  • .gitmodules: Language not supported
  • content/blog/2025/05-01_visible/index_cache/markdown_strict/__packages: Language not supported
  • themes/hugo-igloo: Language not supported

Comment on lines +1 to 2
baseURL = "./"
theme = "hugo-igloo"
Copy link
Preview

Copilot AI Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the baseURL from an empty string to a relative path ('./') may impact link resolution or asset loading in production. Consider using an environment-specific absolute URL for production or documenting the intent clearly.

Suggested change
baseURL = "./"
theme = "hugo-igloo"
baseURL = "https://drmowinckels.io" # Set to the production domain for consistent link resolution and asset loading

Copilot uses AI. Check for mistakes.

[markup.goldmark.renderer]
unsafe = true
[markup.goldmark.parser]
wrapStandAloneImageWithinParagraph = false
Copy link
Preview

Copilot AI Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The property name 'wrapStandAloneImageWithinParagraph' appears to use mixed case for 'standAlone'; consider using 'wrapStandaloneImageWithinParagraph' if that is the intended configuration key as per documentation.

Suggested change
wrapStandAloneImageWithinParagraph = false
wrapStandaloneImageWithinParagraph = false

Copilot uses AI. Check for mistakes.

@github-actions github-actions bot merged commit e7c6764 into main May 1, 2025
4 checks passed
@github-actions github-actions bot deleted the may25 branch May 1, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending Post pending, scheduled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant